Skip to content

FIX chinese character are hard to deal with in latex #7533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2016
Merged

FIX chinese character are hard to deal with in latex #7533

merged 1 commit into from
Nov 30, 2016

Conversation

NelleV
Copy link
Member

@NelleV NelleV commented Nov 30, 2016

Following the addition of unicode chinese char in the documentation, it failed to build in pdf. This PR aims at fixing this issue.

  • Removed the offending lines and replaced them with the output of the command
    on my computer.
  • The documentation now builds properly using latex.

closes #7443

- Removed the offending lines and replaced them with the output of the command
  on my computer.
- The documentation now builds properly using latex.

closes #7443
@NelleV NelleV added Documentation Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labels Nov 30, 2016
@NelleV NelleV added this to the 2.0 (style change major release) milestone Nov 30, 2016
@efiring
Copy link
Member

efiring commented Nov 30, 2016

Looks good. It also looks like Travis and Appveyor are both swamped.

@NelleV
Copy link
Member Author

NelleV commented Nov 30, 2016

I could upload the pdf, but it is massive (3k pages).

@efiring efiring changed the title [MRG] FIX chinese character are hard to deal with in latex FIX chinese character are hard to deal with in latex Nov 30, 2016
@efiring efiring merged commit 0487ec2 into matplotlib:master Nov 30, 2016
efiring added a commit that referenced this pull request Nov 30, 2016
FIX chinese character are hard to deal with in latex
@efiring
Copy link
Member

efiring commented Nov 30, 2016

Backported to v2.x as ac15633. Thank you--good solution to the problem.

@tacaswell
Copy link
Member

Thanks for cleaning up a mess I made!

@NelleV NelleV deleted the 7443_pdf branch April 8, 2017 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdf doc build is sort of broken
3 participants