Skip to content

DOC replaced dead links with active ones #7539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 1, 2016
Merged

DOC replaced dead links with active ones #7539

merged 2 commits into from
Dec 1, 2016

Conversation

NelleV
Copy link
Member

@NelleV NelleV commented Nov 30, 2016

closes #6678

Replaces dead links with new one. There is a deadline in gitwash, that would be fixed by updating the automatically generated content of gitwash - I did not do anything about this one.

linkchecker also complains about the ssl certificat of the scipy website.

@NelleV NelleV changed the title DOC replaced dead links with active ones [MRG] DOC replaced dead links with active ones Nov 30, 2016
@NelleV NelleV added this to the 2.0 (style change major release) milestone Nov 30, 2016
@@ -69,7 +69,7 @@ figures since the last call. Eric has done a lot of testing on the
user interface toolkits and versions and platforms he has access to,
but it is not possible to test them all, so please report problems to
the `mailing list
<http://mail.python.org/mailman/listinfo/matplotlib users>`__
<http://mail.python.org/mailman/listinfo/matplotlib-users>`__
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https this one

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If http links bother you that much, at some point it'd be nice if you could go through the code and fix those. We are loosing a lot of time in going back on forth on that, and it is a very minor detail that bring little to no benefit to our documentation.

Copy link
Member

@QuLogic QuLogic Dec 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many of these redirect; it saves one request for every click for every user. Just because individually there's not much difference, doesn't mean that collectively there isn't one.

You'll note that I didn't ask to change all the other links that were visible here; just the one that you actually touched.

I was waiting for the gitwash PR because a whole bunch of links are fixed in there already.

@tacaswell
Copy link
Member

Odd that appveyor triggered on this PR...

@tacaswell tacaswell merged commit 0b6898b into matplotlib:v2.x Dec 1, 2016
@tacaswell
Copy link
Member

Merged without a second review as this doc-only.

@QuLogic QuLogic changed the title [MRG] DOC replaced dead links with active ones DOC replaced dead links with active ones Dec 1, 2016
@NelleV NelleV mentioned this pull request Dec 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants