Correctly extend a lognormed colorbar #7552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Those failures look real? Is there a better way to do this that does not require |
|
Turns out the issue is a typo (+ should be a -), in the non-lognorm code I copied into the else statement. Should be fixed now. |
|
|
QuLogic
reviewed
Dec 2, 2016
| cb = ColorbarBase(ax, norm=LogNorm(vmin=0.1, vmax=1000.0), | ||
| orientation='vertical', extend='both') | ||
| assert cb._values[0] >= 0.0 | ||
|
|
| @cleanup | ||
| def test_colorbar_lognorm_extension(): | ||
| # Test that colorbar with lognorm is extended correctly | ||
| ax = plt.gca() |
Current coverage is 66.45% (diff: 100%)@@ master #7552 diff @@
==========================================
Files 109 109
Lines 46780 46785 +5
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 31075 31093 +18
+ Misses 15705 15692 -13
Partials 0 0
|
|
restarted travis just to be sure. |
tacaswell
approved these changes
Dec 3, 2016
|
Appveyor failures look unrelated. |
efiring
added a commit
that referenced
this pull request
Dec 3, 2016
Correctly extend a lognormed colorbar
|
Backported to v2.x as 58b92b2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5201.