Skip to content

DOC: Disable build against Sphinx 1.5.0 #7569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 5, 2016

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Dec 5, 2016

This was deprecated in Sphinx 1.4 and causes a warning in 1.5, which kills the build due to warnings-as-errors.

This is breaking both master and v2.x doc builds, so I will self-merge this after CI passes.

This was deprecated in Sphinx 1.4 and causes a warning in 1.5, which
kills the build due to warnings-as-errors.
@QuLogic QuLogic added this to the 2.0 (style change major release) milestone Dec 5, 2016
@QuLogic QuLogic mentioned this pull request Dec 5, 2016
@anntzer
Copy link
Contributor

anntzer commented Dec 5, 2016

I would just update doc-requirements to require sphinx>=1.4.

@QuLogic
Copy link
Member Author

QuLogic commented Dec 5, 2016

That's only Mar 28, 2016; seems a bit new.

@tacaswell
Copy link
Member

In the process of doing exactly this too.

There are 2 more:

Warning, treated as error:
WARNING: latex_preamble is deprecated. Use latex_elements['preamble'] instead.
Warning, treated as error:
WARNING: latex_font_size is deprecated. Use latex_elements['pointsize'] instead.
02:11 $ git diff
diff --git a/doc/conf.py b/doc/conf.py
index d9619d1..037fc80 100644
--- a/doc/conf.py
+++ b/doc/conf.py
@@ -241,9 +241,6 @@ html_favicon = '_static/favicon.ico'
 # The paper size ('letter' or 'a4').
 latex_paper_size = 'letter'
 
-# The font size ('10pt', '11pt' or '12pt').
-latex_font_size = '11pt'
-
 # Grouping the document tree into LaTeX files. List of tuples
 # (source start file, target name, title, author, document class [howto/manual]).
 
@@ -258,8 +255,9 @@ latex_documents = [
 # the title page.
 latex_logo = None
 
+latex_elements = {}
 # Additional stuff for the LaTeX preamble.
-latex_preamble = r"""
+latex_elements['preamble'] = r"""
    % In the parameters section, place a newline after the Parameters
    % header.  (This is stolen directly from Numpy's conf.py, since it
    % affects Numpy-style docstrings).
@@ -279,14 +277,17 @@ latex_preamble = r"""
    \usepackage{enumitem}
    \setlistdepth{2048}
 """
+latex_elements['pointsize'] = '11pt'
+
 
+# Grouping the document tree into LaTeX files. List of tuples
 # Documents to append as an appendix to all manuals.
 latex_appendices = []
 
 # If false, no module index is generated.
 latex_use_modindex = True
 
-latex_use_parts = True
+latex_toplevel_sectioning = 'part'
 
 # Show both class-level docstring and __init__ docstring in class
 # documentation

@tacaswell
Copy link
Member

We should probably shim it for the sake of people building on top of old system packages.

@tacaswell
Copy link
Member

can you also backport this to 1.5.3-doc?

@QuLogic
Copy link
Member Author

QuLogic commented Dec 5, 2016

latex_elements was added in 0.5, so we don't need anything special; 1.5.3-doc appears to have managed to pin Sphinx to 1.3.1 because your build appears to be working.

Every single builtin extension does not declare whether it is parallel
read safe, causing our warnings-as-errors build to fail no matter what.
@QuLogic QuLogic changed the title DOC: Avoid deprecated latex_use_parts option. DOC: Disable build against Sphinx 1.5.0 Dec 5, 2016
@QuLogic
Copy link
Member Author

QuLogic commented Dec 5, 2016

Sphinx 1.5.0 now warns about a majority of its internal extensions that are not parallel read safe, making it impossible for us to fix right now; I've just changed requirements to not allow 1.5.0.

@QuLogic QuLogic merged commit 984e9b0 into matplotlib:v2.x Dec 5, 2016
@QuLogic QuLogic deleted the fix-sphinx-1.5 branch December 5, 2016 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants