Docs edits #7574
Docs edits #7574
Conversation
| @@ -426,11 +426,11 @@ obscuring data too much. | |||
| fig, (old, new) = plt.subplots(ncols=2, sharey=True) | |||
| with plt.style.context('default'): | |||
| new.boxplot(data, labels=['A', 'B', 'C', 'D']) | |||
| new.set_title('New boxplots') | |||
There was a problem hiding this comment.
Looks like this (And below) is reversed?
There was a problem hiding this comment.
Oops, yes. Fixed and force-pushed.
ace39f8 to
19023d2
Compare
|
|
||
|
|
||
|
|
||
| TEMPORARY NOTES TOM IS KEEPING IN THE SOURCE SO THEY DO NOT GET LOST |
There was a problem hiding this comment.
this is here so I remember to do something about it!
There was a problem hiding this comment.
OK, I can remove that commit if you like. Above, I volunteered to do something about it (other than delete it).
There was a problem hiding this comment.
I'm just going to merge this as-is, an make a note on 'paper' to do something about this.
|
@danielballan can you set the y-scales to |
|
|
||
| with plt.style.context('classic'): | ||
| old.boxplot(data, labels=['A', 'B', 'C', 'D']) | ||
| old.set_title('Old boxplots') | ||
| old.set_title('classic') | ||
|
|
||
| new.set_ylim(bottom=0) |
There was a problem hiding this comment.
If we log-scale the y-axes, this line will need to go.
There was a problem hiding this comment.
Good idea, a log scale would make it easier to see the components here. Done.
|
backported to v2.x as f2c145e |
Congrats on the release!
Reading through the API changes, I was impressed by the detailed instructions for rolling back any given style change (if possible). Very thorough work!
I found some small typos and a placeholder that probably was not meant to be included in the rc. If someone can point me to the relevant issue, I will add a commit properly replacing the placeholder (rather than just deleting it).