Delay fc-list warning by 5s. #7596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
title says 'min', code looks like it is 's' |
tacaswell
reviewed
Dec 9, 2016
| """ | ||
| fontext = get_fontext_synonyms(fontext) | ||
| return [fname for fname in _call_fc_list() |
There was a problem hiding this comment.
From a set represented as a {key: 1, key: 1, ...} dict to a list, yes. I can even document this as a API break :-)
There was a problem hiding this comment.
👍 , please document this. The duck typing of the likely usage is the same.
tacaswell
requested changes
Dec 9, 2016
| fname = six.text_type(fname, sys.getfilesystemencoding()) | ||
| except UnicodeDecodeError: | ||
| continue | ||
| return fnames |
There was a problem hiding this comment.
This looks like it will always come out empty.
|
fixed min->s |
c637d88 to
fec1a93
Compare
tacaswell
approved these changes
Dec 11, 2016
QuLogic
reviewed
Dec 11, 2016
| ``afm.get_fontconfig_fonts`` returns a list of paths and does not check for existence | ||
| ````````````````````````````````````````````````````````````````````````````````````` | ||
|
|
||
| ``afm.get_fontconfig_fonts`` used to return a set of paths encoded as a `{key: 1, ...}` dict, and checked for the existence of the paths. It now returns a list and dropped the existence check, as the same check is performed by the caller (``afm.findSystemFonts``) as well. |
There was a problem hiding this comment.
Pretty sure the backticks are the wrong way here, in that single ticks are references and double are code formatting (or at least the dict one needs to be doubled if the other references are not wanted.)
We do not need to check filename validity in `_call_fc_list` as `findSystemFonts` already does it.
fec1a93 to
823fd95
Compare
|
Backported to v2.x as 93d09be. |
This was referenced Dec 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative for #7532.
This implementation also avoids calling
fc-listtwice.We do not need to check filename validity in
_call_fc_listasfindSystemFontsalready does it.