Legend autopositioning with "spiraling" lines. #7625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have no idea what is going wrong with the docs build, it is failing on finding a source file? This seems reasonable, but needs a whats_new entry as a) it is cool! b) is under some views an API change so it should be documented (particularly now that 'auto' is the default legend location). |
Fix computation of the intersection between a line and a prospective
legend position by passing ``filled=False`` to ``line.intersects_bbox``.
This fixes autopositioning of the legend e.g. with
plt.plot([0, 0, 1, 1, 0], [0, 1, 1, 0, 0], label="foo")
plt.legend()
where the legend should be placed "inside" the area enclosed by the
line.
74e365a to
e64f3fb
Compare
|
No idea what's happening about the build failure either. Added a what's new entry although I'm not particularly happy with my wording, so suggestions are welcome. |
dstansby
approved these changes
Jan 29, 2017
|
Nice improvement, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix computation of the intersection between a line and a prospective
legend position by passing
filled=Falsetoline.intersects_bbox.This fixes autopositioning of the legend e.g. with
where the legend should be placed "inside" the area enclosed by the
line.