Save SVG test directly to file instead of its name. #7668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows doesn't like opening files twice, so this needs to save to the file name _outside_ the context (after it's been closed), or simply write to the file object directly. There doesn't seem to be any pressing need to use the file name, so just use the file object.
|
Not sure why this didn't fail in #6428 originally, but the timing seems close enough. |
Current coverage is 62.07% (diff: 100%)@@ master #7668 diff @@
==========================================
Files 109 174 +65
Lines 46633 56007 +9374
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 31049 34765 +3716
- Misses 15584 21242 +5658
Partials 0 0
|
|
Yay, it passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows doesn't like opening files twice, so this needs to save to the file name outside the context (after it's been closed), or simply write to the file object directly. There doesn't seem to be any pressing need to use the file name, so just use the file object.
Hopefully, this will fix AppVeyor.