-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Change majority of redirected links in docs #7693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.. [3] http://matplotlib.1069221.n5.nabble.com/Matplotlib-gallery-td762.html#a33379091 | ||
.. [4] http://www.loria.fr/~rougier/teaching/matplotlib/ | ||
.. [5] http://www.loria.fr/~rougier/coding/gallery/ | ||
.. [4] http://www.labri.fr/perso/nrougier/teaching/matplotlib/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a typo? Would have guessed it should be http://www.labri.fr/person/rougier/teaching/matplotlib/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be a typo on that website, yes!
/perso/ works, but http://www.labri.fr/person/nrougier/teaching/matplotlib/ gives a 404
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"perso" = French abbrev. for "personal" so it's probably intended as such.
(FWIW, I've checked that these work by hand, apart from the http --> https changes) |
@QuLogic is going to love this PR 😄 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some typos, improvements, etc.
or | ||
`32 bit <http://www.microsoft.com/download/en/details.aspx?id=29>`__ | ||
`32 bit <http://www.microsoft.com/en-us/download/details.aspx?id=29>`__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can add https on this one too.
or | ||
`32 bit <http://www.microsoft.com/download/en/details.aspx?id=29>`__ | ||
`32 bit <http://www.microsoft.com/en-us/download/details.aspx?id=29>`__ | ||
for Python 2.7) or Microsoft Visual C++ 2010 ( | ||
`64 bit <http://www.microsoft.com/en-us/download/details.aspx?id=14632>`__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this one and the one after it too.
with LaTeX. | ||
`FFmpeg <https://www.ffmpeg.org/>`_, `avconv <https://libav.org/>`_, | ||
`mencoder <http://www.mplayerhq.hu>`_, or | ||
`ImageMagick <http://www.imagemagick.org/>`_ are required for the | ||
`ImageMagick <http://www.imagemagick.org/script/index.php>`_ are required for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's an unfortunate redirect; would have been nice if they didn't do that.
@@ -146,7 +146,7 @@ python, numpy, libpng and freetype), you can build matplotlib:: | |||
python setup.py install | |||
|
|||
We provide a `setup.cfg | |||
<https://github.com/matplotlib/matplotlib/raw/master/setup.cfg.template>`_ | |||
<https://raw.githubusercontent.com/matplotlib/matplotlib/master/setup.cfg.templatef>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra f
added at the end here.
@@ -20,7 +20,7 @@ Abstract | |||
|
|||
Wrap all of the matplotlib getter and setter methods with python | |||
`properties | |||
<http://docs.python.org/2/library/functions.html#property>`_, allowing | |||
<https://docs.python.org/2/library/functions.html#property>`_, allowing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change 2 to 3.
|
||
|
||
dateutil | ||
The `dateutil <https://dateutil.readthedocs.io>`_ library | ||
provides extensions to the standard datetime module | ||
|
||
EPS | ||
Encapsulated Postscript (`EPS <http://en.wikipedia.org/wiki/Encapsulated_PostScript>`_) | ||
Encapsulated Postscript (`EPS <https://en.wikipedia.org/w/index.php?title=Encapsulated_PostScript>`_) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why all this extra stuff? (This applies to every wiki link in this file.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They were throwing a weird warning with linkcheker when I just added https, but they seem to be fine in the actual build like that. I'll change them back and just add https.
@@ -240,8 +240,8 @@ Here is the solution:: | |||
|
|||
**Extra credit**: use the animation blit techniques discussed in the | |||
`animations recipe | |||
<http://www.scipy.org/Cookbook/Matplotlib/Animations>`_ to make the | |||
animated drawing faster and smoother. | |||
<http://scipy-cookbook.readthedocs.io/items/Matplotlib_Animations.html>`_ to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https-able.
@@ -152,7 +152,7 @@ Troubleshooting | |||
|
|||
.. _LaTeX: http://www.tug.org | |||
.. _dvipng: http://www.nongnu.org/dvipng/ | |||
.. _Ghostscript: http://www.cs.wisc.edu/~ghost/ | |||
.. _Ghostscript: http://pages.cs.wisc.edu/~ghost/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switch to ghostscript.com like the others?
@@ -674,7 +674,7 @@ class is even handier, and prettier to use. Whenever you want to | |||
>>> point.datum | |||
|
|||
By: Alex Martelli | |||
From: http://aspn.activestate.com/ASPN/Cookbook/Python/Recipe/52308 | |||
From: http://code.activestate.com/recipes/121294/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https-able.
@@ -869,7 +869,7 @@ def flatten(seq, scalarp=is_scalar_or_string): | |||
['John', 'Hunter', 1, 23, 42, 5, 23] | |||
|
|||
By: Composite of Holger Krekel and Luther Blissett | |||
From: http://aspn.activestate.com/ASPN/Cookbook/Python/Recipe/121294 | |||
From: http://code.activestate.com/recipes/121294/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https-able.
It's probably not a good idea to modify the gitwash links and instead regenerate them from the original sources (which should be correct now) like @NelleV did in her PR. This will also need a rebase after the other PR. |
That should be rebased and all the changes requested added, I don't how to regenerate the gitwash links, so feel free to commit to my branch to do that! |
Oh, that did not do what I thought it would do at all. @dstansby Do you mind cleaning up the mess I made or may I force-push to your branch? |
I've undone the merge of master, and rebased again, which I presume was the aim? |
Current coverage is 62.07% (diff: 100%)@@ master #7693 diff @@
==========================================
Files 174 174
Lines 56022 56022
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 34776 34774 -2
- Misses 21246 21248 +2
Partials 0 0
|
Yes, thanks! |
For the record, I used the 'resolve conflict' button that I assume everyone with push rights can see. |
Thanks for the pull request @dstansby ! |
Change majority of redirected links in docs Conflicts: doc/devel/MEP/MEP12.rst - previously not backported changes to text still not backported doc/devel/release_guide.rst - conflicts due to 2.x not having been merged up in a while, a no longer existing link was fixed on master. doc/mpl_toolkits/index.rst - manually fixed some links, master has reorganized this doc/thirdpartypackages/index.rst - does not exist on this branch
Thanks, backported to v2.x as dba5232 |
Having a play around with the sphinx linkchecker. This PR replaces quite a few links that redirect.
I'll open another PR in a bit for actual broken website changes as opposed to just redirects.