Set slider to min/max constraint when value exceeds constraint. #770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when a slider's limits are constrained by another slider (using `slidermin/slidermax`), the slider will simply return unchanged when you move the slider beyond the limits. Instead, the slider should update to the min/max value when `closedmin/closedmax` attributes are True. This would match the behavior of the `valmin/valmax` limits.
|
This change looks ok to me. Sorry for the delay. Tony, I take it that you haven't encountered any issues with this change? |
|
I've used it a bit on a simple interactive plot and it worked perfectly for my purposes. And I can't see why there would be any corner cases. Thanks for reviewing. |
|
Agreed. Pulling... |
WeatherGod
added a commit
that referenced
this pull request
May 14, 2012
Set slider to min/max constraint when value exceeds constraint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a slider's limits are constrained by another slider (using
slidermin/slidermax), the slider will simply return unchanged when you move the slider beyond the limits.Instead, the slider should update to the min/max value when
closedmin/closedmaxattributes are True. This would match the behavior of thevalmin/valmaxlimits.