Skip to content

BF: Convert namespace path to list #7703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2016

Conversation

matthew-brett
Copy link
Contributor

For some reason, on some systems, the __path__ attribute of a module
is a _NamespacePath, not a list, as we expected - see:
MacPython/matplotlib-wheels#2

For some reason, on some systems, the ``__path__`` attribute of a module
is a _NamespacePath, not a list, as we expected - see:
MacPython/matplotlib-wheels#2
@tacaswell tacaswell added this to the 2.0 (style change major release) milestone Dec 29, 2016
@WeatherGod
Copy link
Member

Does it have anything to do with how the module is packaged? Say, a zipped egg versus an egg directory? While I am sure this change is fairly innocuous, would it fully address issues arising from the circumstances of these weird situations (in other words, would a path as a namespace path still be useful here?)

@tacaswell
Copy link
Member

tacaswell commented Dec 29, 2016

This is only affecting a local variable that If we don't cast there is some way of getting an incomprehensible exception (that has now eaten 8-10 hours of my and @matthew-brett 's collective time).

This is a private function only used a bit further down to sort out what the full directory is to be able to look for the baseline images in the correct place.

(side note cookies are weird, same random version of forward and back browsing lost and then re-found my draft of this text)

@codecov-io
Copy link

codecov-io commented Dec 29, 2016

Current coverage is 62.07% (diff: 100%)

Merging #7703 into master will increase coverage by <.01%

@@             master      #7703   diff @@
==========================================
  Files           174        174          
  Lines         56022      56022          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          34774      34775     +1   
+ Misses        21248      21247     -1   
  Partials          0          0          

Powered by Codecov. Last update 32fd303...10d94ae

@tacaswell tacaswell merged commit b12b6a7 into matplotlib:master Dec 29, 2016
tacaswell added a commit that referenced this pull request Dec 29, 2016
@tacaswell
Copy link
Member

Thanks! Backported to v2.x as c51f5ca

@matthew-brett
Copy link
Contributor Author

Ben - good suggestion about the packaging - I hadn't thought of that - but no, at least installing from the wheel seems to be the same as installing from source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants