-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
[NF] Add 'truncate' and 'join' methods to colormaps. #7716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
ea42661
NF - Add 'truncate' and 'join' methods to colormaps.
lkilcher e15203a
Some pep8 fixes.
lkilcher 42bdcb0
Update .join docstring to include the parameter.
lkilcher 60ebf94
Move methods to `Colorbar`.
lkilcher f06bf46
Add the __add__ method, and doc.
lkilcher 81ddd1c
Add a `name` parameter to `truncate`
lkilcher 71742d7
Refactor onto a 'join_colormaps' function
lkilcher fa9f56a
Some ideas for a colormap __getitem__ method.
lkilcher aba18e0
Fix some floating-point arithmetic issues for low-N.
lkilcher 652b4cf
Simplify getitem.
lkilcher c2bd712
Add more tests.
lkilcher 6f0a342
pep8
lkilcher 9de0239
Add whats_new and update docstring
lkilcher 48172c7
Compare cmap values in tests (not image comparisons)
lkilcher 8592695
pep8 fixes
lkilcher 17e576e
Increase coverage.
lkilcher 9caba24
Test: 100% coverage!
lkilcher 2384d0b
Merge branch 'master' into colormap_utils
lkilcher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add more tests.
- Loading branch information
commit c2bd7129bcd49308094449f0e6328724a2333ad6
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.96 KB
lib/matplotlib/tests/baseline_images/test_colorbar/colorbar_join_frac.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-1.89 KB
lib/matplotlib/tests/baseline_images/test_colorbar/colorbar_join_listed.png
Binary file not shown.
Binary file removed
BIN
-1.87 KB
lib/matplotlib/tests/baseline_images/test_colorbar/colorbar_join_listed_frac.png
Binary file not shown.
Binary file removed
BIN
-1.96 KB
lib/matplotlib/tests/baseline_images/test_colorbar/colorbar_join_lsc.png
Binary file not shown.
Binary file removed
BIN
-1.92 KB
lib/matplotlib/tests/baseline_images/test_colorbar/colorbar_join_lsc_frac.png
Binary file not shown.
Binary file added
BIN
+2.11 KB
...tplotlib/tests/baseline_images/test_colorbar/colorbar_trunc-getitem-int-1jN.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.73 KB
lib/matplotlib/tests/baseline_images/test_colorbar/colorbar_trunc-getitem-int.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.11 KB
lib/matplotlib/tests/baseline_images/test_colorbar/colorbar_trunc-getitem.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.13 KB
lib/matplotlib/tests/baseline_images/test_colorbar/colorbar_truncate.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-1.83 KB
lib/matplotlib/tests/baseline_images/test_colorbar/colorbar_truncate_listed.png
Binary file not shown.
Binary file removed
BIN
-1.77 KB
lib/matplotlib/tests/baseline_images/test_colorbar/colorbar_truncate_lsc.png
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this requires image comparisons (which are repo-heavy). Can you just test on the returned colormaps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Jody! I hadn't thought of this, but it makes sense. Are the colormaps sitting somewhere that I can compare to, or... ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Levi, I'd just evaluate the colormap at 5 or 6 locations and assert that the values returned are what you say they should be. That seems trivial but if someone mucks with your code they will have to also change the test and thats a good warning to double check what was done.