Skip to content

For make raw_input compatible with python3 #7729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 11, 2017
Merged

For make raw_input compatible with python3 #7729

merged 2 commits into from
Jan 11, 2017

Conversation

rishikksh20
Copy link
Contributor

Fix issue #7388

@tacaswell
Copy link
Member

Can you either un-densify this (we enforce pep8/pycodestlye as part of our test suite) or use from six.moves import input?

@tacaswell tacaswell added this to the 2.0.1 (next bug fix release) milestone Jan 3, 2017
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either add new lines or use from six.moves import input

@rishikksh20
Copy link
Contributor Author

rishikksh20 commented Jan 3, 2017

Ok @tacaswell first let me add new lines if its work for pep8 issue then done. Otherwise I will use
from six.moves import input and then squash all my commits .

This commit remove the pep8 warning from this file
@rishikksh20
Copy link
Contributor Author

@tacaswell its done please review it and let me know if any other modification required.

@codecov-io
Copy link

Current coverage is 62.12% (diff: 100%)

Merging #7729 into master will not change coverage

@@             master      #7729   diff @@
==========================================
  Files           174        174          
  Lines         56028      56028          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          34805      34805          
  Misses        21223      21223          
  Partials          0          0          

Powered by Codecov. Last update 20315e1...fdf4d61

@tacaswell
Copy link
Member

Please do not backport this until after 2.0 final is out.

@QuLogic
Copy link
Member

QuLogic commented Jan 30, 2017

Backported to v2.0.0-doc as 68d2327.

QuLogic pushed a commit that referenced this pull request Jan 30, 2017
For make raw_input compatible with python3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants