bugfix for wx backend: release mouse on loss of focus and before trying to recapture #7752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 62.11% (diff: 0.00%)@@ master #7752 diff @@
==========================================
Files 174 174
Lines 56028 56034 +6
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 34805 34805
- Misses 21223 21229 +6
Partials 0 0
|
|
attn @dhyams |
QuLogic
approved these changes
Jan 20, 2017
| @@ -1023,20 +1026,31 @@ def _onKeyUp(self, evt): | |||
| evt.Skip() | |||
| FigureCanvasBase.key_release_event(self, key, guiEvent=evt) | |||
|
|
|||
| def _set_capture(self, capture=True): | |||
There was a problem hiding this comment.
I don't see it being called anywhere without a value, so maybe the default value isn't necessary.
There was a problem hiding this comment.
What would be gained by removing the default value?
There was a problem hiding this comment.
Enforced explicitness at all callers (if that's what's required).
There was a problem hiding this comment.
@QuLogic Sorry, I do not understand the meaning of your response -- If what is required?
The call signature is part of the documentation. Turning a keyword arg into a positional arg makes the code less readable. Won't change.
NelleV
approved these changes
Jan 24, 2017
|
Thanks @newville |
|
backported to 2.0.x by 5a895da |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #7652 to address #7636 in which wx._core.PyAssertionError would be raised with a message of
For more background, see the discussion in the above links and also at https://groups.google.com/forum/#!topic/wxpython-users/-NrlWBMNkwM .
WxPython "mouse capture" events are quite different on Windows and Posix, and there could be OS-specific code to achieve the same desired behavior (that the mouse can move out of a mpl canvas and back in without errors and without losing mouse events). The solution here is simple enough and works (AFAICT) on all platforms.