Skip to content

Remove redundant pep8 entry in .travis.yml. #7769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 9, 2017

pytest-based tests already run pep8 (as can be checked with pytest -k pep8).

(Alternatively the pep8-only runner could be kept and the corresponding
tests removed from the pytest runners.)

pytest-based tests already run pep8 (as can be checked with `pytest -k
pep8`).

(Alternatively the pep8-only runner could be kept and the corresponding
tests removed from the pytest runners.)
Copy link
Member

@phobson phobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am strongly in favor of this as spinning up a whole instance for just pep8 checking seems a bit overkill.

While I understand that it was nice to have a clear separation of failures between code behavior and style, I think this is more pragmatic.

@phobson phobson changed the title Remove redundant pep8 entry in .travis.yml. [MRG+1] Remove redundant pep8 entry in .travis.yml. Jan 9, 2017
Copy link
Contributor

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a big 👍 from me as well. I'd like to have @tacaswell weight in before we merge though.

@tacaswell
Copy link
Member

We probably should turn pep8 off on one of the pytest runs as well.

@tacaswell tacaswell merged commit a4bd3ce into matplotlib:master Jan 10, 2017
@QuLogic QuLogic added this to the 2.1 (next point release) milestone Jan 10, 2017
@QuLogic QuLogic changed the title [MRG+1] Remove redundant pep8 entry in .travis.yml. Remove redundant pep8 entry in .travis.yml. Jan 19, 2017
@anntzer anntzer deleted the remove-redundant-pep8-in-travis branch February 23, 2017 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants