DOC: remove JDH memorial block; other front page tweaks; credits #7772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Names of people extracted from git, the current count is 600 (!?). The text should also include a sentence like 'The following people have contributed code to the Matplotlib code base. This does not account for the many people who have made valuable contributions by reporting bugs, answering questions, and teaching over the years." #! /bin/bash
echo 'time&name' > commits_time_author.csv;
git log --pretty=format:'%at&%aN <%aE>' >> commits_time_author.csvimport pandas as pd
commits = pd.read_csv('commits_time_author.csv', sep='&')
au = set(commits.name)
nn = set(n.split('<')[0] for n in au)
print(sorted(nn))It is easy to sort this by commit count, but I think alphabetical is better. |
|
Or |
|
But I know how to use this hammer 😉 |
|
I would remove the mention of matlab. While it was certainly relevant 10 years ago, I don't think it is relevant today. matplotlib is not going to be either a reason or a roadblock to migrating matlab code to python. |
I would love to live in your world--for many my sector, MATLAB is what they know of, not this weird Python thing. Even if at a code level moving to matplotlib isn't smooth, mentioning MATLAB as a reference point for similar plotting functionality is useful. |
|
There are surely more improvements that can be made, but I think this PR is now merge-ready as a reasonably self-contained and complete increment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the front page, in addition to removing the memorial:
I'm tempted to remove the reference to Matlab also; is it doing us any good? Maybe it is helpful as an indication of our historical origins.
The credits page needs the actual contributors list from git followed by formatting and editing.