-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Api doc backport no imag build #7779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api doc backport no imag build #7779
Conversation
By default, don't include tests in binary distributions.
Update to include details about how to re-enable.
@@ -201,6 +201,20 @@ replaced by ``nipy_spectral`` and ``nipy_spectral_r`` since matplotlib | |||
raised a warning. As of matplotlib 2.0.0, using the old names raises a | |||
deprecation warning. In the future, using the old names will raise an error. | |||
|
|||
Default install does not include test images |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does not include -> no longer includes
To reduce the default size of wheels and source installs, the tests | ||
and baseline images are no longer included by default. | ||
|
||
To restore installing the tests and images have a `setup.cfg` with :: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
images have -> images, use
(or add)
@@ -79,10 +79,15 @@ Alternatively, if you do :: | |||
pip install -v ./ | |||
|
|||
all of the files will be copied to the installation directory however, | |||
you will have to rerun this command every time the source is changed. | |||
you will have to rerun this command every time the source is changed. Additionally you will | |||
need to copy :file:`setup.cfg.template` to :file:`setup.cfg` and edit to contain :: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edit to -> edit it to
Apparently we have moved to using develop on the master branch, but not in 2.x.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the minor comments (which IMO are minor enough that they can be ignored), this looks good.
👍
Default install does not include test images | ||
-------------------------------------------- | ||
|
||
To reduce the default size of wheels and source installs, the tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't "default" an extra word here?
@@ -22,10 +22,10 @@ | |||
|
|||
[packages] | |||
# There are a number of subpackages of matplotlib that are considered |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
matplotlib -> Matplotlib
(trying to catch them as they come…)
08be52f
to
9cff712
Compare
9cff712
to
ca6bb75
Compare
Took 3 tries, but I think I got all of them. |
Thanks! |
backport of #7757 + docs