Skip to content

MAINT tests should not use relative imports #7829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2017
Merged

MAINT tests should not use relative imports #7829

merged 1 commit into from
Jan 16, 2017

Conversation

NelleV
Copy link
Member

@NelleV NelleV commented Jan 14, 2017

If they do, they cannot be run independently.

If they do, they cannot be run independantly
@tacaswell tacaswell added this to the 2.0.1 (next bug fix release) milestone Jan 14, 2017
@codecov-io
Copy link

codecov-io commented Jan 14, 2017

Current coverage is 62.10% (diff: 100%)

Merging #7829 into master will not change coverage

@@             master      #7829   diff @@
==========================================
  Files           174        174          
  Lines         56052      56052          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          34809      34809          
  Misses        21243      21243          
  Partials          0          0          

Powered by Codecov. Last update 9edcb03...2207bfe

@NelleV NelleV changed the title MAINT tests should not use relative imports [MRG+1] MAINT tests should not use relative imports Jan 15, 2017
Copy link
Contributor

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch--a definite no-no.

@dopplershift dopplershift merged commit 3b9a92d into matplotlib:master Jan 16, 2017
@dopplershift dopplershift changed the title [MRG+1] MAINT tests should not use relative imports MAINT tests should not use relative imports Jan 16, 2017
@QuLogic
Copy link
Member

QuLogic commented Jan 30, 2017

This does not need backporting.

@QuLogic QuLogic modified the milestones: 2.1 (next point release), 2.0.1 (next bug fix release) Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants