MAINT moved all "d" modules to pytest. #7885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I removed the corresponding commit. |
efiring
reviewed
Jan 20, 2017
| @@ -1,12 +1,12 @@ | |||
| from __future__ import (absolute_import, division, print_function, | |||
| unicode_literals) | |||
|
|
|||
| import six | |||
There was a problem hiding this comment.
I don't see where the import is useful.
There was a problem hiding this comment.
Yeah, I'm not able to find any use of six. in that file.
There was a problem hiding this comment.
Sorry, I wasn't thinking properly.
Current coverage is 62.17% (diff: 100%)@@ master #7885 diff @@
==========================================
Files 174 174
Lines 56121 56121
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 34894 34896 +2
+ Misses 21227 21225 -2
Partials 0 0
|
QuLogic
approved these changes
Jan 20, 2017
phobson
approved these changes
Jan 21, 2017
|
Used Github's UI to resolve a merge conflict that came from merging the test_c* PR before this one. I'll let the CI run and then finish the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the modules starting by "d" from nosetests to pytest.