Skip to content

MAINT vega colormaps are deprecated in favor of tab #7971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2017
Merged

MAINT vega colormaps are deprecated in favor of tab #7971

merged 2 commits into from
Jan 29, 2017

Conversation

NelleV
Copy link
Member

@NelleV NelleV commented Jan 28, 2017

This patch deprecates the vega colormaps in favor of tab.
These colormaps were accidentally added in 2.0 before we decided on the name. This corrects this small mistake.

@NelleV NelleV added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Jan 28, 2017
@anntzer anntzer changed the title MAINT vega colormaps are deprecated in favor of tab [MRG+1] MAINT vega colormaps are deprecated in favor of tab Jan 28, 2017
@dstansby dstansby added this to the 2.0.1 (next bug fix release) milestone Jan 29, 2017
Deprecations
------------

- The "Vega" colormaps are deprecated in Matplotlib 2.0.1 and will be removed
Copy link
Member

@dstansby dstansby Jan 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth mentioning that they are simply being renamed, and that the "tab" colormaps are exactly the same as the now-old "vega" colormaps.

@NelleV
Copy link
Member Author

NelleV commented Jan 29, 2017

@dstansby Done!

Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (pending tests running first set of tests passed, and the small doc change shouldn't break testing)

@dstansby dstansby self-assigned this Jan 29, 2017
@dstansby dstansby merged commit 8d41551 into matplotlib:v2.0.x Jan 29, 2017
@QuLogic QuLogic changed the title [MRG+1] MAINT vega colormaps are deprecated in favor of tab MAINT vega colormaps are deprecated in favor of tab Jan 29, 2017
@dstansby dstansby removed their assignment Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants