Skip to content

Switch testing to pytest completely #7974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 3, 2017
Merged

Switch testing to pytest completely #7974

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6a91b9a
Use pip to install in AppVeyor too.
QuLogic Jan 29, 2017
ab99e65
Rename test_only to avoid pytest collection.
QuLogic Jan 31, 2017
bd91b93
Remove pytest collection filter.
QuLogic Jan 31, 2017
25fdef8
Move pytest_configure into installed area.
QuLogic Jan 31, 2017
c8fc318
Enable pytest-xdist on AppVeyor.
QuLogic Jan 31, 2017
02d7cf8
Change stack level of Figure.gca warning.
QuLogic Jan 31, 2017
30e40c6
Skip broken category test with NumPy < 1.8.0.
QuLogic Jan 31, 2017
80281e9
Use pytest in matplotlib.test().
QuLogic Feb 1, 2017
c520c2c
Stop installing nose in CI.
QuLogic Feb 1, 2017
ed7d353
FIX: implement `__ne__` for `SubplotSpec`
tacaswell Feb 1, 2017
ca255dd
Normalize path case before checking for fonts.
QuLogic Feb 1, 2017
3cb2752
Fix one last old xfail call.
QuLogic Feb 1, 2017
857d846
Fix tests.py when passed explicit filenames.
QuLogic Feb 3, 2017
fe20a23
Always upload coverage on Travis.
QuLogic Feb 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
FIX: implement __ne__ for SubplotSpec 
In python3 `__ne__` automatically delegates to `__eq__`, in python2 it
does not and falls back to the default `__ne__` test.  The NumPy
version of `assert_equal` actually checks `if a != b: raise`, whereas the
version of `assert_equal` from `unittest` (where `nose` ultimately
pulls from) checks `if not a == b: raise`
  • Loading branch information
@tacaswell @QuLogic
tacaswell authored and QuLogic committed Feb 2, 2017
commit ed7d353a7e8c3127378727f0eb4fb2d790ef0364
5 changes: 4 additions & 1 deletion lib/matplotlib/gridspec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,6 @@ def get_position(self, fig, return_all=False):
else:
return figbox


def get_topmost_subplotspec(self):
'get the topmost SubplotSpec instance associated with the subplot'
gridspec = self.get_gridspec()
Expand All @@ -473,6 +472,10 @@ def __eq__(self, other):
self.num1 == other.num1,
self.num2 == other.num2))

if six.PY2:
def __ne__(self, other):
return not self == other

def __hash__(self):
return (hash(self._gridspec) ^
hash(self.num1) ^
Expand Down