Skip to content

Fix cmap deprecation (again) #7986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 30, 2017
Merged

Fix cmap deprecation (again) #7986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2daee2
Fix another datad[cmapname] that didn't exist in master.
QuLogic Jan 30, 2017
a8a769d
Fix grammar of Vega cmap deprecation message.
QuLogic Jan 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/matplotlib/_cm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1384,11 +1384,11 @@ def __getitem__(self, key):
"Vega20b_r", "Vega20c", "Vega20c_r"]:
warn_deprecated(
"2.0",
name="Vega colormaps",
alternative="tab",
name=key,
alternative="tab" + key[4:],
obj_type="colormap"
)

return super(_deprecation_datad, self).__getitem__(key)


Expand Down
3 changes: 2 additions & 1 deletion lib/matplotlib/cm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@ def _generate_cmap(name, lutsize):

# Generate the reversed specifications ...
for cmapname in list(six.iterkeys(datad)):
spec = datad[cmapname]
# Use superclass method to avoid deprecation warnings during initial load.
spec = dict.__getitem__(datad, cmapname)
spec_reversed = _reverse_cmap_spec(spec)
datad[cmapname + '_r'] = spec_reversed

Expand Down