Add vega deprecations to tests on master #7987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit nicer for debugging.
NelleV
approved these changes
Jan 30, 2017
QuLogic
referenced
this pull request
Jan 30, 2017
jkseppan
reviewed
Jan 30, 2017
| with warnings.catch_warnings(record=True) as w: | ||
| warnings.simplefilter('always') | ||
| cmap = plt.get_cmap(name) | ||
| assert len(w) == (1 if name in should_have_warning else 0) |
There was a problem hiding this comment.
How about adding some more data in the AssertionError message if this doesn't match? Something like
assert len(w) == (1 if name in should_have_warning else 0), (name, [wg.message for wg in w])would help the next person who wants to debug why this assertion is failing.
There was a problem hiding this comment.
Well, name is already available though the parametrization and will be printed as part of the test name. Pytest also prints out w, but unfortunately using the repr which doesn't look that great for warnings, so maybe adding that to the message wouldn't be a bad idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The merge up broke this. Sorry about that.