Simplify implementation of is_numlike & is_string_like. #7996
+12
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
story645
requested changes
Jan 31, 2017
| except: | ||
| return False | ||
| return True | ||
| return isinstance(obj, (six.string_types, np.str_)) |
There was a problem hiding this comment.
Ah the joys of Py2... fixed.
bdfa250 to
6b716cf
Compare
story645
approved these changes
Jan 31, 2017
|
I half expected this patch to break all our tests… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #7795 and #7835 for the motivation. Note that this PR does not actually deprecate either function -- just replaces them by a "saner" implementation (as argued in the issues).