Simplify mpl.testing._copy_metadata. #8102
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`mpl.testing._copy_metadata` was basically doing the job of `functools.update_wrapper`. We don't need to specify `compat_co_firstlineono` either as pytest will look up the lineno in the wrapped function (https://github.com/pytest-dev/pytest/blob/master/_pytest/compat.py#L188). It's also for this reason that we need to make sure `__wrapped__` is properly set, even on Py2. Also remove a useless check on `image_comparison` (if we want an argument to be compulsory then just mark it as such, this does not prevent it to be passed as keyword).
|
Actually there's no way (AFAICT) to make this easily work because setting |
|
Implmented in #9300. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mpl.testing._copy_metadatawas basically doing the jobof
functools.update_wrapper. We don't need to specifycompat_co_firstlineonoeither as pytest will look upthe lineno in the wrapped function
(https://github.com/pytest-dev/pytest/blob/master/_pytest/compat.py#L188).
It's also for this reason that we need to make sure
__wrapped__is properly set, even on Py2.Also remove a useless check on
image_comparison(if we want anargument to be compulsory then just mark it as such, this does not
prevent it to be passed as keyword).