Skip to content

pgf: Fix invalid arguments passed to pdftocairo. #8127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2017
Merged

pgf: Fix invalid arguments passed to pdftocairo. #8127

merged 1 commit into from
Feb 22, 2017

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Feb 22, 2017

This breaks saving PNG when using the PGF backend.

Fixes #8121.

@QuLogic
pgf: Fix invalid arguments passed to pdftocairo.
c0d5a14 
This breaks saving PNG when using the PGF backend.

Fixes matplotlib#8121.
@QuLogic QuLogic added this to the 2.0.1 (next bug fix release) milestone Feb 22, 2017
@tacaswell
Copy link
Member

The only non-whitespace change is to drop shell=True?

@QuLogic
Copy link
Member Author

QuLogic commented Feb 22, 2017 •
edited
Loading

To split "-r %d" into two arguments (shell=True was only necessary because of it, but didn't seem to work any more.)

anntzer
anntzer approved these changes Feb 22, 2017
View reviewed changes
Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@anntzer anntzer changed the title pgf: Fix invalid arguments passed to pdftocairo. [MRG+1] pgf: Fix invalid arguments passed to pdftocairo. Feb 22, 2017
@tacaswell tacaswell merged commit bef5a8e into matplotlib:v2.0.x Feb 22, 2017
@QuLogic QuLogic deleted the fix-pgf-to-png branch February 22, 2017 06:06
@QuLogic QuLogic changed the title [MRG+1] pgf: Fix invalid arguments passed to pdftocairo. pgf: Fix invalid arguments passed to pdftocairo. Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
backend: pgf
Projects
None yet
Milestone
v2.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @tacaswell @anntzer