Skip to content

Update Slider docs and type check slidermin and slidermax. #8134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 25, 2017
Merged

Update Slider docs and type check slidermin and slidermax. #8134

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a4694a0
DOC: numpydoc-ify widget.Slider.
heathhenley Feb 23, 2017
36ad946
Raise ValueError if slidermin/max incompatible.
heathhenley Feb 23, 2017
f59028e
Dry out bounds checking for reuse.
heathhenley Feb 23, 2017
9f4258b
Lint: tabs to spaces.
heathhenley Feb 23, 2017
ffba7d9
Tests for widgets.Slider.
heathhenley Feb 23, 2017
9d3e5e1
Doc nit.
heathhenley Feb 23, 2017
ea899aa
Improve test coverage.
heathhenley Feb 23, 2017
dc55f80
Bounds check returns value.
heathhenley Feb 23, 2017
325789a
FIX nitpicks on docstring
NelleV Feb 24, 2017
2b42285
Fix: indent error
heathhenley Feb 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Lint: tabs to spaces.
  • Loading branch information
@heathhenley
heathhenley committed Feb 23, 2017
commit 9f4258b456a49f463f87ac05a44fd1cbbeb10c5c
12 changes: 6 additions & 6 deletions lib/matplotlib/widgets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,11 +291,11 @@ def __init__(self, ax, label, valmin, valmax, valinit=0.5, valfmt='%1.2f',

valinit : float, optional
The slider initial position.
Default: 0.5
Default: 0.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the default on the line that defines the parameter?
(note that it is currently not indented properly).


valfmt : str, optional
Used to format the slider value, fprint format string.
Default: '%1.2f'
Default: '%1.2f'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same (Can you add the default on the line that defines the parameter?)


closedmin : bool, optional
Indicate whether the slider interval is closed on the bottom.
Expand Down Expand Up @@ -370,11 +370,11 @@ def __init__(self, ax, label, valmin, valmax, valinit=0.5, valfmt='%1.2f',
self.slidermin = slidermin
self.slidermax = slidermax
self.drag_active = False
self._value_in_bounds(valinit)
self._value_in_bounds(valinit)

def _value_in_bounds(self, val):
""" Makes sure self.val is with given bounds."""
if val <= self.valmin:
if val <= self.valmin:
if not self.closedmin:
return
val = self.valmin
Expand Down Expand Up @@ -416,8 +416,8 @@ def _update(self, event):
event.canvas.release_mouse(self.ax)
return
val = event.xdata
self._value_in_bounds(val)
self._value_in_bounds(val)

def set_val(self, val):
xy = self.poly.xy
xy[2] = val, 1
Expand Down