Plot errorbars when fmt == 'none' #8163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
commented
Feb 27, 2017
lib/matplotlib/tests/test_axes.py
Outdated
| plotline, _, barlines = plt.errorbar(x, y, xerr=1, yerr=1, fmt='none') | ||
| assert plotline is None | ||
| for errbar in barlines: | ||
| assert np.any(errbar.get_color() != [0, 0, 0, 0]) |
There was a problem hiding this comment.
I'm not sure if this is the best way to check that the errorbars aren't see-through, so other suggestions welcome.
There was a problem hiding this comment.
This color should be 'C0'? I would test against that.
tacaswell
reviewed
Feb 27, 2017
lib/matplotlib/tests/test_axes.py
Outdated
| @@ -2454,6 +2454,17 @@ def test_errorbar_limits(): | |||
| ax.set_title('Errorbar upper and lower limits') | |||
|
|
|||
|
|
|||
| def test_errobar_nonefmt(): | |||
There was a problem hiding this comment.
still need @cleanup on 2.0.x.
|
Anyone wants to give another look at this PR? |
|
Might be worth to re-run AppVeyor (which does not seem to have been run) before merging? |
|
Appveyor does not run on the 2.0.x branch |
|
Ah, this might be the explanation then 😄! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8117.