Skip to content

TST: Enable cache directories on AppVeyor. #8179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 8, 2017

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Mar 2, 2017

No description provided.

@QuLogic QuLogic added this to the 2.1 (next point release) milestone Mar 2, 2017
@QuLogic
Copy link
Member Author

QuLogic commented Mar 2, 2017

Grr, of course, in order to get the cache to help, we need to have one run actually work...

@dstansby
Copy link
Member

dstansby commented Mar 2, 2017

I'll watch the Appveyor build and restart it until it passes...

@QuLogic
Copy link
Member Author

QuLogic commented Mar 3, 2017

If this finally works this time, I'm going to push another commit and hopefully we'll see that the cache is working.

@QuLogic
Copy link
Member Author

QuLogic commented Mar 3, 2017

Pushed another commit to hopefully fix caching on Python 2; 50% of AppVeyor builds are on Python 2. This line shows that Python 2 is trying to put the tarball into the cache now.

@QuLogic QuLogic force-pushed the appveyor-cache branch 3 times, most recently from 95ac596 to 65e3e9a Compare March 3, 2017 05:01
except OSError:
# Don't care if it exists.
pass
try:
shutil.copy(tarball_cache_path, tarball_path)
print('Using cached tarball: {}'
.format(tarball_cache_path))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The except just below could probably be just for OSError?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fixed, BTW.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@QuLogic
Copy link
Member Author

QuLogic commented Mar 8, 2017

On Travis, Python 2.7, Python 3.4, Python 3.5, Python 3.6, Python 2.7 on macOS and Python nightly are all using the cached tarball now.

AppVeyor is not, still. I don't know what's up with it. Maybe caching only works once its gone through master?

@QuLogic
Copy link
Member Author

QuLogic commented Mar 8, 2017

When I run this on master in my own copy, AppVeyor includes some more lines about updating the build cache. These do not appear in the builds here, so I assume this won't be enabled until it's merged into master.

@QuLogic
Copy link
Member Author

QuLogic commented Mar 8, 2017

The second build shows AppVeyor restoring the cache and Matplotlib using the cached tarball, so I think this needs to be merged to have any effect on AppVeyor.

Interestingly, for those builds, I commented out the test run and it turns out that installing dependencies and building Matplotlib (note, this occurs twice on AppVeyor) take up about 50% of the test wall time, except in the last full-test case.

@anntzer
Copy link
Contributor

anntzer commented Mar 8, 2017

Something like https://github.com/mozilla/sccache / https://github.com/inorton/cclash / https://github.com/frerich/clcache (basically ccache with msvc support) could be useful?

@QuLogic
Copy link
Member Author

QuLogic commented Mar 8, 2017

I was thinking of something like that, but never investigated it. Probably something for another time, when the build queue is not so long...

@NelleV
Copy link
Member

NelleV commented Mar 8, 2017

I think we can merge this PR. It looks good to me.

@NelleV NelleV changed the title TST: Enable cache directories on AppVeyor. [MRG+1] TST: Enable cache directories on AppVeyor. Mar 8, 2017
@dstansby dstansby changed the title [MRG+1] TST: Enable cache directories on AppVeyor. TST: Enable cache directories on AppVeyor. Mar 8, 2017
@dstansby dstansby merged commit 6d4eeff into matplotlib:master Mar 8, 2017
@dstansby
Copy link
Member

dstansby commented Mar 8, 2017

Lets see what happens once appveyor gets round to this merge...

@QuLogic QuLogic deleted the appveyor-cache branch March 9, 2017 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants