Skip to content

Mep12 text labels and annotations #8211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 8, 2017
Merged

Mep12 text labels and annotations #8211

merged 4 commits into from
Mar 8, 2017

Conversation

NelleV
Copy link
Member

@NelleV NelleV commented Mar 7, 2017

Here are some more migrations of examples to compatible sphinx-gallery docstring.

refs #7206

@NelleV NelleV changed the title Mep12 text labels and annotations [MRG] Mep12 text labels and annotations Mar 7, 2017
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo.

Controlling style of text and labels using a dictionary
=======================================================


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra line.



This example shows how to share parameters across many text objects and labels
by creating a dictionnaries of option passed across several functions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dictionnaries of option -> dictionary of options

@NelleV
Copy link
Member Author

NelleV commented Mar 7, 2017

Thanks for the review! I fixed the comments.

Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still one typo ;)

=======================================================

This example shows how to share parameters across many text objects and labels
by creating a dictionnary of options passed across several functions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dictionnary ->dictionary

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed again :)

@QuLogic QuLogic changed the title [MRG] Mep12 text labels and annotations [MRG+1] Mep12 text labels and annotations Mar 7, 2017
@tacaswell tacaswell added this to the 2.0.1 (next bug fix release) milestone Mar 7, 2017

Matplotlib can wrap text automatically, but if it's too long, the text will be
displayed slightly outside of the boundaries of the axis anyways.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick grep suggests that the common style in the codebase is an empty line after the closing quotes, not before.

Also applies below.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have common style code for documenting examples? And here I thought we didn't have documentation on examples :p

@NelleV
Copy link
Member Author

NelleV commented Mar 7, 2017

I've added/removed blank lines.

Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge if the doc build on travis passes 👍

@dstansby dstansby self-assigned this Mar 7, 2017
@NelleV
Copy link
Member Author

NelleV commented Mar 8, 2017

So… The documentation passes. The rest fails because it can't download freetype.

@dstansby dstansby merged commit e88957d into matplotlib:master Mar 8, 2017
@dstansby dstansby removed their assignment Apr 10, 2017
dstansby added a commit that referenced this pull request May 1, 2017
@dstansby
Copy link
Member

dstansby commented May 1, 2017

Backported to 2.0.x via. 605e57b

@QuLogic QuLogic changed the title [MRG+1] Mep12 text labels and annotations Mep12 text labels and annotations May 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants