Implement Path.intersects_bbox in C++ to speed up legend positioning. #8224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
requested changes
Mar 7, 2017
| (the default value), there is no change in behavior. For those rare cases where | ||
| ``Path.intersects_bbox`` was called with ``filled`` set to ``False`` and where | ||
| the old behavior is actually desired, the suggested workaround is to call | ||
| ``Path.intersects_path`` with a rectangle as the path: |
There was a problem hiding this comment.
I think you need to end the paragraph with two colons (::) so that what follows is treated as a code block.
You can just commit --amend and force push.
There was a problem hiding this comment.
I will edit this myself after Appveyor passes (it is actually important for this PR), and skip the rebuild.
|
Thanks for this very useful contribution. |
|
That PR uses functions that don't exist anymore. |
|
or I need to rebuild my c code :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squashed version of PR #8126.