changes to MEP12/sphinx-gallery compliant #8233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NelleV
approved these changes
Mar 8, 2017
|
|
||
| import numpy as np |
There was a problem hiding this comment.
I wonder how this example even ran without numpy…
There was a problem hiding this comment.
It did not, so the question is, why was it not picked up by the gallery?
There was a problem hiding this comment.
http://matplotlib.org/devdocs/examples/mplot3d/pathpatch3d_demo.html super confused now.
There was a problem hiding this comment.
Can you open an issue to track this?
|
Thanks! |
|
I know everyone is keen to merge doc related pull requests, but please wait until at least the documentation build and PEP8 build on travis are complete before merging. It turns out this PR had a PEP8 violation that went by un-noticed. |
Merged
|
Apologies. |
dstansby
pushed a commit
that referenced
this pull request
Apr 30, 2017
[MRG+1] changes to MEP12/sphinx-gallery compliant
|
Backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #7206; similar to #8209