Memoize parse_fontconfig_pattern; speeds up test suite by ~1min. #8252
Conversation
lib/matplotlib/fontconfig_pattern.py
Outdated
| # repeatedly called when the rcParams are reset (to validate the default | ||
| # fonts). In practice, the cache size doesn't grow beyond a few dozen entries | ||
| # during the test suite. | ||
| parse_fontconfig_pattern = lru_cache()(FontconfigPatternParser().parse) | ||
|
|
There was a problem hiding this comment.
Should be another blank line above the function (current ignore list is hiding this.)
On my laptop this patch drops the duration of the test suite from 604s to 554s (with the inkscape patch on as well).
263ac2a to
d8ce993
Compare
|
For the record I have also tried updating the cache on mathtext.parse to use a LRU cache (the current This is probably due to the fact that most of that time is actually spent in |
|
Thanks @anntzer ! |
On my laptop this patch drops the duration of the test suite from 604s
to 554s (with the inkscape patch on as well).
(The fontconfig syntax is simple enough that one could also probably write a simple regex parser.)
attn @NelleV