-
-
Notifications
You must be signed in to change notification settings - Fork 8k
FIX: round instead of truncate Agg canvas size #8265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
tacaswell
wants to merge
6
commits into
matplotlib:main
Choose a base branch
from
tacaswell:fix_stable_pixel_size_rounding
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
19630b2
FIX: round instead of truncate Agg canvas size
tacaswell 01e261e
MNT: if the figure size is not changed, bail early
tacaswell 85867e0
API: when forwarding figure resize, round not truncate pixel numbers
tacaswell 80a7a02
TST: regenerate a test image
tacaswell 701ae74
API: feedback to figure size due to pixel counts
tacaswell 7acb303
API: add API change note
tacaswell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
Round instead of truncating pixel number when using Agg | ||
``````````````````````````````````````````````````````` | ||
|
||
When rasterizing a figure the allowed figure sizes are effectively | ||
discretized by the finite dpi. Previously, we simply truncated when | ||
computing the number of pixels to use, now we use `numpy.round` which | ||
will avoid floating point issues when setting the size of the figure | ||
in inches to get a specific size of in pixels. | ||
|
||
Additionally, the Agg based backends will adjust the size of the | ||
figure to match the actual size (given by the number of pixels and the | ||
dpi) during the draw process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+125 Bytes
(100%)
lib/matplotlib/tests/baseline_images/test_arrow_patches/boxarrow_test_image.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-121 Bytes
(100%)
...tlib/tests/baseline_images/test_bbox_tight/bbox_inches_tight_suptile_legend.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-7 Bytes
(100%)
lib/mpl_toolkits/axes_grid1/tests/baseline_images/test_axes_grid1/image_grid.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+151 Bytes
(100%)
...1/tests/baseline_images/test_axes_grid1/image_grid_each_left_label_mode_all.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-10 Bytes
(100%)
...tests/baseline_images/test_axes_grid1/image_grid_single_bottom_label_mode_1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we fully trust this with the way we handle HiDPI (where
figure.dpi
changes based on screen)?