Skip to content

Removes OldScalarFormatter #7956 #8295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 17, 2017
Merged

Removes OldScalarFormatter #7956 #8295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
27de919
Removes OldScalarFormatter
NinadBhat Mar 14, 2017
71a4eb8
Renaming file to scalarformatter_demo.py
NinadBhat Mar 14, 2017
a8af90e
Renaming to plot_scalarformatter.py
NinadBhat Mar 14, 2017
a218217
Adds title and description
NinadBhat Mar 14, 2017
eab3d7f
changing name in backend_driver.py
NinadBhat Mar 14, 2017
375fd31
Correcting typos and moving file to ticks and spines
NinadBhat Mar 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/tests/backend_driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@
'multiline.py',
'multiple_figs_demo.py',
'nan_test.py',
'newscalarformatter_demo.py',
'plot_scalarformatter.py',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NelleV: This should go to files['ticks_and_spines'] right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understood properly from a conversation with @tacaswell, this file is way out of date and unmaintained.
@tacaswell can you confirm or correct this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you're thinking of #8069?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I think of a later discussion (last week or so)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once #8069 goes through all these explicit example file references will be gone anyway, so I don't think this matters.

'pcolor_demo.py',
'pcolor_log.py',
'pcolor_small.py',
Expand Down
40 changes: 15 additions & 25 deletions ...pylab_examples/newscalarformatter_demo.py → .../ticks_and_spines/plot_scalarformatter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,31 +1,21 @@
import matplotlib.pyplot as plt
import numpy as np
from matplotlib.ticker import OldScalarFormatter, ScalarFormatter
"""
=========================================
Tick formatting using the ScalarFromatter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still a typo here (that I am fine fixing just before merging).

=========================================

# Example 1
x = np.arange(0, 1, .01)
fig, [[ax1, ax2], [ax3, ax4]] = plt.subplots(2, 2, figsize=(6, 6))
fig.text(0.5, 0.975, 'The old formatter',
horizontalalignment='center', verticalalignment='top')
ax1.plot(x * 1e5 + 1e10, x * 1e-10 + 1e-5)
ax1.xaxis.set_major_formatter(OldScalarFormatter())
ax1.yaxis.set_major_formatter(OldScalarFormatter())

ax2.plot(x * 1e5, x * 1e-4)
ax2.xaxis.set_major_formatter(OldScalarFormatter())
ax2.yaxis.set_major_formatter(OldScalarFormatter())
The example shows use of ScalarFormatter with different settings.

ax3.plot(-x * 1e5 - 1e10, -x * 1e-5 - 1e-10)
ax3.xaxis.set_major_formatter(OldScalarFormatter())
ax3.yaxis.set_major_formatter(OldScalarFormatter())
Example 1 : Default

ax4.plot(-x * 1e5, -x * 1e-4)
ax4.xaxis.set_major_formatter(OldScalarFormatter())
ax4.yaxis.set_major_formatter(OldScalarFormatter())
Example 2 : With no Numerical Offset

fig.subplots_adjust(wspace=0.7, hspace=0.6)
Example 3 : With Mathtext
"""
import matplotlib.pyplot as plt
import numpy as np
from matplotlib.ticker import ScalarFormatter

# Example 2
# Example 1
x = np.arange(0, 1, .01)
fig, [[ax1, ax2], [ax3, ax4]] = plt.subplots(2, 2, figsize=(6, 6))
fig.text(0.5, 0.975, 'The new formatter, default settings',
Expand All @@ -50,7 +40,7 @@

fig.subplots_adjust(wspace=0.7, hspace=0.6)

# Example 3
# Example 2
x = np.arange(0, 1, .01)
fig, [[ax1, ax2], [ax3, ax4]] = plt.subplots(2, 2, figsize=(6, 6))
fig.text(0.5, 0.975, 'The new formatter, no numerical offset',
Expand All @@ -75,7 +65,7 @@

fig.subplots_adjust(wspace=0.7, hspace=0.6)

# Example 4
# Example 3
x = np.arange(0, 1, .01)
fig, [[ax1, ax2], [ax3, ax4]] = plt.subplots(2, 2, figsize=(6, 6))
fig.text(0.5, 0.975, 'The new formatter, with mathtext',
Expand Down