Added ContourSet clip_path kwarg and set_clip_path() method (#2369) #8321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are some conflicts now, but this seems reasonable. Not sure why it didn't get traction... |
jklymak
requested changes
Jan 19, 2018
|
Thanks a lot for the contribution. I'm going to close this as having had no action for quite a while. OTOH, if there is still a community that wants this, please feel free to re-open, with my apologies! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds implementation for issue #2369.
Implemented
clip_pathkwarg,get_clip_path(), andset_clip_path()in ContourSet.Added unit tests, and baseline images for image comparison.
We added both options of setting the
clip_pathas described in issue #2369 in case of a refactor of the ContourSet kwargs. (i.e.plt.contourf(data, clip_path=poly)andplt.contourf(data).set_clip_path(poly))