Don't index into __builtins__ (not supported by PyPy). #8331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
reviewed
Mar 18, 2017
| @@ -6147,13 +6147,6 @@ def _normalize_input(inp, ename='input'): | |||
| if bins is None: | |||
| bins = rcParams['hist.bins'] | |||
|
|
|||
| # xrange becomes range after 2to3 | |||
| bin_range = range | |||
There was a problem hiding this comment.
I have a slight preference for
bin_range = range
del rangeIt causes less code churn and keeps the code below clearer
There was a problem hiding this comment.
sounds reasonable, fixed
dd45300 to
0519ea3
Compare
QuLogic
approved these changes
Mar 19, 2017
lib/matplotlib/axes/_axes.py
Outdated
| @@ -6147,12 +6147,9 @@ def _normalize_input(inp, ename='input'): | |||
| if bins is None: | |||
| bins = rcParams['hist.bins'] | |||
|
|
|||
| # xrange becomes range after 2to3 | |||
| # Avoid shadowing the builtin. | |||
There was a problem hiding this comment.
There's a lot of code between the argument definition and the renaming here; I think this really should be the first thing in the function to avoid any and all possible shadowing.
There was a problem hiding this comment.
sounds reasonable, fixed.
0519ea3 to
7eee4c2
Compare
|
Thanks @anntzer ! |
QuLogic
pushed a commit
to QuLogic/matplotlib
that referenced
this pull request
Mar 27, 2017
Don't index into __builtins__ (not supported by PyPy).
|
Backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf #8330.