Renamed all 'mtrans' into more common 'mtransforms' #8338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from "as mtrans" into "as mtransforms"
|
You'll need to fix the lines that became too long and cause PEP8 violations (https://travis-ci.org/matplotlib/matplotlib/jobs/212698819). |
|
Oh thanks for pointing that out 👍 I'll fix it right away |
|
still not there... you may want to run the checks locally. |
|
I have run |
phobson
approved these changes
Mar 21, 2017
NelleV
approved these changes
Mar 21, 2017
|
Thanks @sindunuragarp |
|
Thanks for the suggestion! I'll keep that in mind 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking through the codebase, I found that the
matplotlib.transformsmodule was imported twice inmatplotlib.axes._axeswith two different names, namelymtransandmtransforms. I found that the latter was a more common usage therefore I renamed allmtransusages intomtransforms.