symlog + minor ticks = exception #8367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NelleV
approved these changes
Mar 23, 2017
|
Note: this PR was approved already by @phobson. |
|
Thanks @ColinDruery for this contribution! I'll merge as soon as the CI stuff finish running. |
phobson
approved these changes
Mar 23, 2017
QuLogic
pushed a commit
to QuLogic/matplotlib
that referenced
this pull request
Mar 27, 2017
symlog + minor ticks = exception
|
Backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the reopened pull request for #8353
Issues with commits should now be resolved.
Calling minorticks_on() with symlog previously caused an exception. This fix passes a transform object into the SymmetricalLogLocator instead of a float type. Appended tests to verify minorticks_on() works with various combinations of log and symlog. I believe this should solve the issue described in #6967.