-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Cleanup appveyor.yml. #8368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup appveyor.yml. #8368
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about this unquoting; at least according to this SO answer, anything with a wide range of special characters should be quoted.
.appveyor.yml
Outdated
@@ -56,31 +56,31 @@ platform: | |||
build: false | |||
|
|||
cache: | |||
- '%LOCALAPPDATA%\pip\Cache' | |||
- '%USERPROFILE%\.cache\matplotlib' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The caching examples explicitly state these should be quoted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, yaml strings are complicated...
AppVeyor does not appear to be running, so something is probably broken. |
972fbab
to
10808ac
Compare
- Rename to `.appveyor.yml`, consistently with `.travis.yml` (https://www.appveyor.com/docs/build-configuration/#yaml-file-alternative-naming). - Remove redundant leading `cmd:` (https://www.appveyor.com/docs/build-configuration/#script-blocks-in-build-configuration "By default, script line is treated as batch command"). - Remove redundant quotes (w.r.t. yaml format); minor formatting changes. - Replace `git clean -d -x -f` by `git clean -xdfq` to shorten the log.
10808ac
to
76aca8e
Compare
Now fixed. |
There're still quite a few |
%s are only a problem if they appear at the beginning of a string (note that the previous version also had a lot of unquoted %s...). |
Ah, that explains the cache entries, then. I know Jekyll had a problem with colons in values, but it seems the YAML parser for AppVeyor is not so problematic. |
(This PR only increased my dislike of yaml. The format looks simple, but it is in fact way too complicated once you look at the details :/) |
.appveyor.yml
, consistently with.travis.yml
(https://www.appveyor.com/docs/build-configuration/#yaml-file-alternative-naming).cmd:
(https://www.appveyor.com/docs/build-configuration/#script-blocks-in-build-configuration "By default, script line is treated as batch command").git clean -d -x -f
bygit clean -xdfq
to shorten the log.