Skip to content

Cleanup appveyor.yml. #8368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2017
Merged

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 24, 2017

Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this unquoting; at least according to this SO answer, anything with a wide range of special characters should be quoted.

.appveyor.yml Outdated
@@ -56,31 +56,31 @@ platform:
build: false

cache:
- '%LOCALAPPDATA%\pip\Cache'
- '%USERPROFILE%\.cache\matplotlib'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The caching examples explicitly state these should be quoted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, yaml strings are complicated...

@QuLogic
Copy link
Member

QuLogic commented Mar 24, 2017

AppVeyor does not appear to be running, so something is probably broken.

@anntzer anntzer force-pushed the cleanup-appveyor-yml branch 3 times, most recently from 972fbab to 10808ac Compare March 24, 2017 04:36
- Rename to `.appveyor.yml`, consistently with `.travis.yml` (https://www.appveyor.com/docs/build-configuration/#yaml-file-alternative-naming).
- Remove redundant leading `cmd:` (https://www.appveyor.com/docs/build-configuration/#script-blocks-in-build-configuration "By default, script line is treated as batch command").
- Remove redundant quotes (w.r.t. yaml format); minor formatting changes.
- Replace `git clean -d -x -f` by `git clean -xdfq` to shorten the log.
@anntzer anntzer force-pushed the cleanup-appveyor-yml branch from 10808ac to 76aca8e Compare March 24, 2017 04:47
@anntzer
Copy link
Contributor Author

anntzer commented Mar 24, 2017

Now fixed.

@QuLogic
Copy link
Member

QuLogic commented Mar 24, 2017

There're still quite a few % that appear unquoted but it seems to work...

@anntzer
Copy link
Contributor Author

anntzer commented Mar 24, 2017

%s are only a problem if they appear at the beginning of a string (note that the previous version also had a lot of unquoted %s...).

@QuLogic
Copy link
Member

QuLogic commented Mar 24, 2017

Ah, that explains the cache entries, then. I know Jekyll had a problem with colons in values, but it seems the YAML parser for AppVeyor is not so problematic.

@anntzer
Copy link
Contributor Author

anntzer commented Mar 24, 2017

(This PR only increased my dislike of yaml. The format looks simple, but it is in fact way too complicated once you look at the details :/)

@dstansby dstansby added this to the 2.1 (next point release) milestone Mar 24, 2017
@dstansby dstansby merged commit 75babe6 into matplotlib:master Mar 24, 2017
@anntzer anntzer deleted the cleanup-appveyor-yml branch March 24, 2017 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants