Use cbook._reshape_2D in hist. #8369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... instead of rewriting essentially the same function locally. The warning regarding potentially transposed inputs could be restored if we consider it to be really worth it, but it probably belongs to `_reshape_2D` anyways as it also applies to box plots.
phobson
approved these changes
Mar 24, 2017
dstansby
approved these changes
Mar 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... instead of rewriting essentially the same function locally. The
warning regarding potentially transposed inputs could be restored
if we consider it to be really worth it, but it probably belongs to
_reshape_2Danyways as it also applies to box plots.attn @NelleV, xref #8116.