Skip to content

DOC update build dependencies #8374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 5, 2017
Merged

DOC update build dependencies #8374

merged 3 commits into from
Apr 5, 2017

Conversation

NelleV
Copy link
Member

@NelleV NelleV commented Mar 24, 2017

This complements #8373 and updates the README file to reflect graphviz is also a dependency.

Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to dismiss once you consider the issues fixed.

doc/README.txt Outdated

All of these dependencies can be installed through pip::
* Sphinx-1.3 or later(Version 1.5.0 is not supported)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space, I would also drop "Version" (or at least make it "version")

doc/README.txt Outdated
* Sphinx-1.3 or later(Version 1.5.0 is not supported)
* numpydoc 0.4 or later
* IPython
* Mock
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mock, lowercase.

doc/README.txt Outdated
* Mock
* colorspacious
* pillow
* graphviz.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no final dot here, or add commas after other items (e.g. first answer at http://english.stackexchange.com/questions/55048/use-of-capitals-and-full-stops-in-bullet-points)

doc/README.txt Outdated
* pillow
* graphviz.

All of these dependencies except graphviz can be installed through pip::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would emphasize (*) "except graphviz".

@NelleV
Copy link
Member Author

NelleV commented Mar 28, 2017

Sorry, I don't have time to fix this. I'm closing this PR: this documentation problem will be perfect for a new contributor to work on.

@NelleV NelleV closed this Mar 28, 2017
@phobson
Copy link
Member

phobson commented Mar 29, 2017

@NelleV Do you mind if I push up to this with a few changes?

@NelleV NelleV reopened this Mar 29, 2017
@NelleV
Copy link
Member Author

NelleV commented Mar 29, 2017

@phobson No, go for it. I reopened the PR and feel free to push.
I won't be able to follow during the next few days (I am at a workshop that's keeping us busy :) )

@phobson phobson dismissed anntzer’s stale review March 29, 2017 14:57

addressed the comments

@tacaswell tacaswell added this to the 2.0.1 (next bug fix release) milestone Apr 2, 2017
Missing word.
@NelleV
Copy link
Member Author

NelleV commented Apr 4, 2017

I fixed an additional typo. I think it should be good.
Thanks @phobson for the help!

@anntzer anntzer merged commit 70d5de6 into matplotlib:master Apr 5, 2017
@anntzer
Copy link
Contributor

anntzer commented Apr 5, 2017

Thanks!

@NelleV NelleV deleted the doc_doc branch April 8, 2017 20:28
tacaswell pushed a commit that referenced this pull request Apr 14, 2017
DOC update build dependencies
@tacaswell
Copy link
Member

backported to v2.0.0-doc as 976692f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants