-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
DOC update build dependencies #8374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feel free to dismiss once you consider the issues fixed.
doc/README.txt
Outdated
|
||
All of these dependencies can be installed through pip:: | ||
* Sphinx-1.3 or later(Version 1.5.0 is not supported) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing space, I would also drop "Version" (or at least make it "version")
doc/README.txt
Outdated
* Sphinx-1.3 or later(Version 1.5.0 is not supported) | ||
* numpydoc 0.4 or later | ||
* IPython | ||
* Mock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mock, lowercase.
doc/README.txt
Outdated
* Mock | ||
* colorspacious | ||
* pillow | ||
* graphviz. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no final dot here, or add commas after other items (e.g. first answer at http://english.stackexchange.com/questions/55048/use-of-capitals-and-full-stops-in-bullet-points)
doc/README.txt
Outdated
* pillow | ||
* graphviz. | ||
|
||
All of these dependencies except graphviz can be installed through pip:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would emphasize (*
) "except graphviz".
Sorry, I don't have time to fix this. I'm closing this PR: this documentation problem will be perfect for a new contributor to work on. |
@NelleV Do you mind if I push up to this with a few changes? |
@phobson No, go for it. I reopened the PR and feel free to push. |
Missing word.
I fixed an additional typo. I think it should be good. |
Thanks! |
DOC update build dependencies
backported to v2.0.0-doc as 976692f |
This complements #8373 and updates the README file to reflect graphviz is also a dependency.