Skip to content

Build docs with oldest numpy on 2.7. #8488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2017
Merged

Build docs with oldest numpy on 2.7. #8488

merged 1 commit into from
Apr 17, 2017

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 15, 2017

Saving some more time on CI, and checking that the docs build with old
numpys as well.

#8232 could probably be closed after that.

@anntzer
Copy link
Contributor Author

anntzer commented Apr 15, 2017

Well, looks like the docs don't build on numpy 1.7.1 :-)

@anntzer anntzer force-pushed the one-fewer-travis-job branch from b1fb778 to 1b3b8d0 Compare April 15, 2017 06:51
@anntzer
Copy link
Contributor Author

anntzer commented Apr 15, 2017

"fixed"

@anntzer anntzer force-pushed the one-fewer-travis-job branch from 1b3b8d0 to 65f09c1 Compare April 15, 2017 19:35
@anntzer
Copy link
Contributor Author

anntzer commented Apr 15, 2017

for real this time.

@phobson phobson changed the title Only build once with 2.7 on Travis. [MRG+1] Only build once with 2.7 on Travis. Apr 16, 2017
tacaswell
tacaswell requested changes Apr 16, 2017
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means we don't run the test suite, only build the docs on py2.7.

@anntzer
Copy link
Contributor Author

anntzer commented Apr 17, 2017

Ah, I see, misunderstood BUILD_DOCS. Let's build the docs with 2.7+oldest numpy then?

@anntzer anntzer force-pushed the one-fewer-travis-job branch from 65f09c1 to 5e249f1 Compare April 17, 2017 00:57
@anntzer
Build docs with oldest numpy on 2.7.
5d64f54 
Some examples needed to be fixed to build on python2.7+numpy1.7.

Delete examples/misc/rec_join_demo.py which is not working on numpy
1.7.1 -- not fixing it, as rec_join is arguably better provided by
pandas-style librairies anyways.
@anntzer anntzer force-pushed the one-fewer-travis-job branch from 5e249f1 to 5d64f54 Compare April 17, 2017 00:57
@QuLogic QuLogic changed the title [MRG+1] Only build once with 2.7 on Travis. Build docs with oldest numpy on 2.7. Apr 17, 2017
@QuLogic
Copy link
Member

QuLogic commented Apr 17, 2017

Don't really need to wait for AppVeyor.

@QuLogic QuLogic merged commit d1947ce into matplotlib:master Apr 17, 2017
@QuLogic QuLogic added this to the 2.1 (next point release) milestone Apr 17, 2017
@anntzer anntzer deleted the one-fewer-travis-job branch April 17, 2017 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@phobson phobson phobson approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @QuLogic @tacaswell @phobson