Remove codecov coverage targets. #8491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
reviewed
Apr 16, 2017
| tests: | ||
| target: 97.9% |
There was a problem hiding this comment.
turned it into "auto", i.e. "greater than the previous value" (97.9 seems to come a bit out of nowhere)
There was a problem hiding this comment.
The 97.9 was a hand tuned value from looking at the coverage on the tests and being happy that what was missed was ok to miss.
There was a problem hiding this comment.
But certainly you don't want it to go down in any case?
There was a problem hiding this comment.
auto seems to be working well enough.
|
attn @dopplershift as (I think) the local code-cov expert. |
6bb5d78 to
3c26e67
Compare
|
Why 0% and not 50% so that it flags if something completely crazy happens? |
As mentioned in the conversation starting at https://gitter.im/matplotlib/matplotlib?at=58eed50a69a692963ea5e238 codecov seems to be failing PR builds on the basis of incorrectly computed coverage deltas. This PR sets the required coverage values to 50%, so that the coverage is still computed but does not affect build anymore unless something dramatic happens.
3c26e67 to
99b3382
Compare
|
sounds good. changed to 50%. |
phobson
approved these changes
Apr 20, 2017
dopplershift
approved these changes
Apr 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the conversation starting at
https://gitter.im/matplotlib/matplotlib?at=58eed50a69a692963ea5e238
codecov seems to be failing PR builds on the basis of incorrectly
computed coverage deltas. This PR sets the required coverage values to
zero, so that the coverage is still computed but does not affect build
anymore.
PR Summary
PR Checklist