Skip to content

Fix rectangular patches to be properly transformed on polar axes #8539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from Apr 28, 2017
Merged

Fix rectangular patches to be properly transformed on polar axes #8539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2430cc4
fixed polar bug
Apr 26, 2017
4a8c60e
base line image and test case for polar projection
Apr 26, 2017
48afb3c
image for test case polar projection bug
Apr 26, 2017
fbe6bcf
putting polar projection test case into the right file
Apr 27, 2017
8469cf9
putting polar projection test cases into appropriate files and folders
Apr 27, 2017
9a3952e
fixed test case to meet pep8
Apr 27, 2017
0247871
Delete test_proj_on_rect_patch.py
Apr 27, 2017
feb5b87
Update test_patches.py
Apr 27, 2017
8dae4e1
Update test_patches.py
Apr 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/matplotlib/axes/_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1856,6 +1856,8 @@ def add_patch(self, p):
if p.get_clip_path() is None:
p.set_clip_path(self.patch)
self._update_patch_limits(p)
if self.name != 'rectilinear':
p.get_path()._interpolation_steps = max(p.get_path()._interpolation_steps, 100)
self.patches.append(p)
p._remove_method = lambda h: self.patches.remove(h)
return p
Expand Down
Binary file added lib/matplotlib/tests/baseline_images/test_patches/polar_proj.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
14 changes: 14 additions & 0 deletions lib/matplotlib/tests/test_patches.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,3 +337,17 @@ def test_multi_color_hatch():
with mstyle.context({'hatch.color': 'C{}'.format(i)}):
r = Rectangle((i-.8/2, 5), .8, 1, hatch='//', fc='none')
ax.add_patch(r)


@image_comparison(baseline_images=['polar_proj'], extensions=['png'])
def test_adding_rectangle_patch_with_polar_projection():
fig = plt.figure()
ax = fig.add_subplot(111, projection='polar')

# add quadrant as example
ax.add_patch(
mpatches.Rectangle(
(0, 1), width=np.pi * 0.5, height=0.5
)
)
ax.set_rmax(2)