Only install doc requirements if building docs on travis #8580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
power-cycled to rut CI against current branches. I am a bit confused why this did not fix the 3.7 tests (which have been failing because installing the doc requirements fails due to scipy not having 3.7 wheels and travis not having all of the build deps which I thought meant sphinx did not get installed). |
|
This seems to reduce coverage on the tests? Looks like it is pandas-related... |
|
Lets see if a rebase does anything... |
|
Can you also install |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was having a look through
.travis.ymland noticed that the doc requirements get installed all the time. This PR only installs the requirements if the docs are being built. The extra sphinx dependency is needed for tests inlib/matplotlib/sphinxextwhich are run during normal testing.