Move some examples out of pylab_examples #8633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I have wanted to move the examples away from pylab examples for a long time |
QuLogic
reviewed
May 16, 2017
examples/color/color_demo.py
Outdated
| @@ -22,12 +22,12 @@ | |||
| import matplotlib.pyplot as plt | |||
| import numpy as np | |||
|
|
|||
| plt.subplot(111, facecolor='darkslategray') | |||
| #subplot(111, facecolor='#ababab') | |||
| fig, ax = plt.subplots(facecolor='darkslategray') | |||
There was a problem hiding this comment.
Since this is mostly all changing, I'd put this after the data generation.
| @@ -11,8 +11,8 @@ | |||
| # unit area ellipse | |||
| rx, ry = 3., 1. | |||
| area = rx * ry * pi | |||
| theta = arange(0, 2*pi + 0.01, 0.1) | |||
| verts = list(zip(rx/area*cos(theta), ry/area*sin(theta))) | |||
| theta = arange(0, 2 * pi + 0.01, 0.1) | |||
| @@ -25,7 +25,7 @@ | |||
| plt.subplot(323) | |||
| plt.scatter(x, y, s=80, c=z, marker=(verts, 0)) | |||
| # equivalent: | |||
| #plt.scatter(x,y,s=80, c=z, marker=None, verts=verts) | |||
| # plt.scatter(x,y,s=80, c=z, marker=None, verts=verts) | |||
There was a problem hiding this comment.
Add spaces after comma here too?
QuLogic
approved these changes
May 20, 2017
QuLogic
requested changes
May 20, 2017
PEP8 moved examples Move subplots and scatter examples PEP8 scatter examples Small example fixes Remove old barchart demos Add new barchart demo back
|
After a bit of rebase fun and a fix of the broken doc links, this should be working now. |
|
@Kojoley Any idea why AppVeyor is now unable to find |
|
I restarted appveyor, and all seems to be fine now. |
|
Oh, I didn't realize this wasn't merged yet; might be a few conflicts with #8677. |
QuLogic
approved these changes
May 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've moved a few of the pylab_examples to more relevant folders, and PEP8 cleaned them. Also got rid of
pylab_examples/READMEwhich doesn't seem to be adding much...