Fix tests against pytest 3.1 #8655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pytest 3.1 now has this plugin rolled into itself.
All because of the mixed subplots test which marks one extension as xfail. This was technically not checked correctly, but ended up with the same result of the 'svg' extension being treated as xfail.
tacaswell
reviewed
May 23, 2017
| @@ -94,7 +94,7 @@ install: | |||
| - echo %PYTHON_VERSION% %TARGET_ARCH% | |||
| - if %PYTHON_VERSION% == 2.7 conda install -q backports.functools_lru_cache | |||
| # pytest-cov>=2.3.1 due to https://github.com/pytest-dev/pytest-cov/issues/124 | |||
| - pip install -q pytest "pytest-cov>=2.3.1" pytest-rerunfailures pytest-timeout pytest-warnings pytest-xdist | |||
| - pip install -q pytest "pytest-cov>=2.3.1" pytest-rerunfailures pytest-timeout pytest-xdist | |||
There was a problem hiding this comment.
do we not use pytest-warnings anymore?
There was a problem hiding this comment.
it's explained in the git log message
Pytest 3.1 now has this plugin rolled into itself.
|
Merged despite my question to un-break master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds are currently broken as the latest pytest 3.1.0 has just hit the builders. It seems there's a bug in the Marker comparison function which breaks test collection.
This is a bit of a hack until the upstream bug is fixed, though I'd be open to just not allowing 3.1.0 instead.This is actually a bug but only surfaced due to another behavioural change in pytest.