Skip to content

WebAgg backend: Fix unbound variable error in get_diff_image #8656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2017
Merged

WebAgg backend: Fix unbound variable error in get_diff_image #8656

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edb5868
keep the old buffer so we can return something when get_diff_image is…
cknd May 23, 2017
f38575e
let get_diff_image return None and deal with it downstream
cknd May 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/matplotlib/backends/backend_webagg_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,8 +236,7 @@ def get_diff_image(self):
self._last_renderer, renderer)
self._force_full = False
self._png_is_old = False

return buff
return buff

def get_renderer(self, cleared=None):
# Mirrors super.get_renderer, but caches the old one
Expand Down Expand Up @@ -487,8 +486,9 @@ def handle_json(self, content):
def refresh_all(self):
if self.web_sockets:
diff = self.canvas.get_diff_image()
for s in self.web_sockets:
s.send_binary(diff)
if diff is not None:
for s in self.web_sockets:
s.send_binary(diff)

@classmethod
def get_javascript(cls, stream=None):
Expand Down