Fix typos #8709
Merged
Fix typos #8709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Jun 3, 2017
| @@ -3698,7 +3698,7 @@ coordT *qh_readpoints(int *numpoints, int *dimension, boolT *ismalloc) { | |||
| strncat(qh rbox_command, s, sizeof(qh rbox_command)-1); | |||
| } | |||
| if (!s) { | |||
| qh_fprintf(qh ferr, 6074, "qhull input error: missing \"begin\" for cdd-formated input\n"); | |||
| qh_fprintf(qh ferr, 6074, "qhull input error: missing \"begin\" for cdd-formatted input\n"); | |||
There was a problem hiding this comment.
Better to send these upstream instead.
tacaswell
reviewed
Jun 3, 2017
| @@ -677,7 +677,7 @@ Pull Requests (1003): | |||
| * :ghpull:`7548`: Clarify to_rgba docstring. | |||
| * :ghpull:`7476`: Sticky margins | |||
| * :ghpull:`7552`: Correctly extend a lognormed colorbar | |||
| * :ghpull:`7499`: Improve the the marker table in markers_api documentation | |||
| * :ghpull:`7499`: Improve the marker table in markers_api documentation | |||
There was a problem hiding this comment.
I just fixed this in the PR title so the next time we generate this file it will stay fixed 👍
tacaswell
approved these changes
Jun 3, 2017
There was a problem hiding this comment.
Provisional on the qhull change. It would be good to push that upstream, but we do not closely track upstream. It is spelling in an error message so I do not think it is harmful to have this change. Will defer to @ianthomas23 on this.
There does not seem to be an upstream for ttconv, but will defer to @mdboom
|
@taehoonlee Thanks for the PR! |
phobson
approved these changes
Jun 6, 2017
|
@taehoonlee (belated) congratulations 🎉 on what I think is your first Matplotlib contribution. Hopefully we will hear from you again! |
|
Thank you @tacaswell! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some typos:
the the,implementaion,seperated,formated,compatiblity,fuction.